RMT API: Add missing get function: rmt_get_idle_level(). Suppress … (IDFGH-1789) #2666
+27
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rror message from rmt_wait_tx_done() if wait_time==0 (allows for polling).
igrr
pushed a commit
that referenced
this pull request
Feb 26, 2019
1. Add missing get function to RMT API: rmt_get_idle_level(). 2. Suppress error message from rmt_wait_tx_done() if wait_time==0 (allows for polling). 3. Remove the blank lines between parameter lists. Merges #2666
igrr
pushed a commit
that referenced
this pull request
Mar 6, 2019
1. Add missing get function to RMT API: rmt_get_idle_level(). 2. Suppress error message from rmt_wait_tx_done() if wait_time==0 (allows for polling). 3. Remove the blank lines between parameter lists. Merges #2666
igrr
pushed a commit
that referenced
this pull request
Mar 7, 2019
1. Add missing get function to RMT API: rmt_get_idle_level(). 2. Suppress error message from rmt_wait_tx_done() if wait_time==0 (allows for polling). 3. Remove the blank lines between parameter lists. Merges #2666
catalinio
pushed a commit
to catalinio/pycom-esp-idf
that referenced
this pull request
Jun 28, 2019
1. Add missing get function to RMT API: rmt_get_idle_level(). 2. Suppress error message from rmt_wait_tx_done() if wait_time==0 (allows for polling). 3. Remove the blank lines between parameter lists. Merges espressif/esp-idf#2666
|
@phatpaul Thanks for the contribution and sorry for the very slow turnaround. The PR has been merged, thanks. |
github-actions
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…error message from rmt_wait_tx_done() if wait_time==0 (allows for polling).
Contributing some improvements I required for my project.
Here's my justification for the changes: #1175 (comment)
I had to redo the PR #2461 to change my local branch and edit my email address to match github.